-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polylines not displayed correctly at long zoom distance on iOS #9035
Comments
Is this related to or the same as #6735 @likangning93 ? |
I should probably add that I am using 1.67 currently as it does not present this issue. One of my colleagues reported to me that it was the latest he found that still worked. |
@sparsematrix that information helps a lot. If you're able to do a git bisect to determine exactly which commit caused this issue, that'd help narrowing it down. That's what I would do next. |
Closing this issue as we have not heard from the original poster in a while and do not have sufficient information to move forward. Please feel free to re-open it to continue the discussion if necessary. |
You have sufficient information. I apologize that I have a greater than full time job and have not yet had time to perform a binary search on commits and determine which one broke it. Your sandcastle example is literally broken. You should need no more information than that. |
Re-opened as #9232 |
@sparsematrix My apologies. I see that we have already confirmed that this is a bug. Re-opening issue to continue the discussion. |
Here is the result of my git bisect testing:
Source/Shaders/Materials/PolylineArrowMaterial.glsl | 1 - |
Thanks for taking the time to look further into this @sparsematrix @kring any ideas? |
Not much @sparsematrix and @hpinkos. That commit was part of a major rework of polyline rendering with the log depth buffer, which fixed a bunch of problems. Since it seems to be working on other platforms (certainly various desktop platforms and on the Android devices I've tried), it could indicate an iOS bug, or it could indicate we're doing something dodgy that other platforms just happen to let us get away with. But nothing jumps out at me as far as the latter, and I don't have an iOS device to debug it on. One thing to try: disable the logarithmic depth buffer and see if that helps. Here's a version of the Materials Sandcastle with log depth disabled. |
Here's the PR that commit was part of: |
@kring Thanks for taking a look. I've given that version a shot on an iPad and it shows the same issue as the regular Materials Sandcastle. |
@kring not sure if any of this helps... Here's how it looks in 1.67 in my app. To get this display there is a PolylineOutline drawn and then a PolylineArrow drawn along the same path to get the appearance of both outline and arrows. The line color is magenta and the outline is black: Moving to commit d631c21, which is just before the breaking commit. The outline issue is not present but PolylineArrow no longer draws at all in iOS (still works in Chrome) regardless of zoom level: Moving to the breaking commit c5ac455. When zoomed out I only see the outline color. Zooming in tight at this commit results in the correct appearance of both the outline and arrow (seemingly fixing the arrow issue seen in d631c21): I have updated one of my iPads to the latest iOS (14.4.1) and confirmed that it is still an issue there with the Sandcastle example. |
I have confirmed that this issue remains in iOS 14.5.1 |
Updated to iOS 15.4.1 and Cesium 1.92. Here's my latest results in Safari/WKWebView:
|
Remaining issues appear to be covered by #9827 and setting orderIndependentTranslucency to false does appear to resolve the issue. |
I have seen this in my app which uses WKWebView and also with the default Materials example when loaded in iOS Safari.
Sandcastle example: https://sandcastle.cesium.com/?src=Materials.html
Browser: iOS Safari
Operating System: iOS 13.4 and 13.5.1
The text was updated successfully, but these errors were encountered: