Polylines (and other geometry?) created in 2D no longer cull correctly in 3D

[mramato]

1. Run the materials demo: http://localhost:8080/Apps/Sandcastle/index.html?src=Materials.html&label=All
2. Switch to 2D.
3. Select Polyline Arrow from the bottom combo box.
4. Switch to 3D
5. The polyline will be drawn even when it is behind the ellipsoid (it does disappear at some point when it's completely on the other side of the center of the earth)

[TJKoury]

This is not just an issue with ground polygons, I'm seeing this in 3D with points (and polylines).

[IanLilleyT]

The problem is depth test is being permanently turned off for the primitive after creating it in 2D. Depth test should be turned back on when going back to 3D, but it's not.

Left is when creating the polyline in 2D, Right is when creating it in 3D first:

Looking deeper, the OIT derived translucent command creates its render state from the derived log depth command, and so if the polyline was created in 2D mode, it forever inherits the depth test off property.

cesium/Source/Scene/OIT.js

Lines 563 to 566 in d07271e

	result.translucentCommand = DrawCommand.shallowClone(
	command,
	result.translucentCommand
	);

and

cesium/Source/Scene/OIT.js

Line 584 in d07271e

result.translucentCommand.renderState = translucentRenderState;

are the culprits.

In subsequent renders, it copies the log depth command render state in the first code block but reverts it back to its original state in the second.

Not sure where to go from here though as I'm not very familiar with these systems.