Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use highp sampler2D when using float textures for tables #8311

Closed
likangning93 opened this issue Oct 22, 2019 · 0 comments · Fixed by #8805
Closed

Use highp sampler2D when using float textures for tables #8311

likangning93 opened this issue Oct 22, 2019 · 0 comments · Fixed by #8805

Comments

@likangning93
Copy link
Contributor

#6739 observed that Cesium's float batch tables didn't seem to be working at high enough precision on some devices.
From https://groups.google.com/forum/#!topic/webgl-dev-list/aFmFGeyRVRQ, devices are free to select the precision of sampler2D when it isn't explicitly set.
We should update our batch table code to use uniform highp sampler2D when backing the batch table with float textures.

As part of this, please roll back changes from #7421 and test on a device that shows red on https://likangning93.github.io/webgl-examples/tests/floatTexturePrecision/ but no red on https://likangning93.github.io/webgl-examples/tests/floatTexturePrecisionHighpSampler/.

Good candidates as of this writing are the iPhone 7 or newer and the first generation iPad Pro or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants