Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliasing on thin models #8228

Closed
OmarShehata opened this issue Sep 30, 2019 · 6 comments
Closed

Fix aliasing on thin models #8228

OmarShehata opened this issue Sep 30, 2019 · 6 comments

Comments

@OmarShehata
Copy link
Contributor

For 3d models that have thin parts (think the frames around a window of a building), when you zoom out or look at them at an angle such that the line occupies a very small area of the screen, you get some very noticable artifacts in CesiumJS.

Model: lines.gltf.zip

How it looks in Blender:

blender

Now if we look at it at an extreme angle:

CesiumJS:
lines_cesium
BabylonJS:
lines_babylon
ThreeJS:
three_lines

I think this is because the other two engines are using MSAA to get the lines to still look decent even when they may be sub-pixel thick.

@mramato
Copy link
Contributor

mramato commented Oct 1, 2019

This is easy to see on the Cesium hot air balloon as well, just zoom out slightly while looking at the ropes holding the basket to the balloon. https://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=3D%20Models.html

@OmarShehata
Copy link
Contributor Author

Came up again on the forum here.

@OmarShehata
Copy link
Contributor Author

Came up again in #8642.

Here's a Sandcastle reproducing essentially the same effect but on a texture. This should be easier to fix because having mipmaps for this texture could help.

@weiyinggh
Copy link

I also encountered the same problem, hope to solve it quickly, thank you!

@blueRaining
Copy link

Came up again in #8642.

Here's a Sandcastle reproducing essentially the same effect but on a texture. This should be easier to fix because having mipmaps for this texture could help.

image
This still looks problematic

@ggetz
Copy link
Contributor

ggetz commented Jun 9, 2023

This should be fixed given MSAA has been implemented - #9900.

@ggetz ggetz closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants