Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestScheduler double counts image fetches in Chrome (using createImageBitmap) #8162

Closed
tephenavies opened this issue Sep 16, 2019 · 2 comments
Closed

RequestScheduler double counts image fetches in Chrome (using createImageBitmap) #8162

tephenavies opened this issue Sep 16, 2019 · 2 comments

Comments

@tephenavies
Copy link
Contributor

RequestScheduler counts requests when startRequest is called:
https://github.com/AnalyticalGraphicsInc/cesium/blob/d9e06b005ba93edf23aaf564dc66a8c0e7aa356c/Source/Core/RequestScheduler.js#L202-L211

But when ImageryProvider calls Resource.fetchImage and the browser supports createImageBitmap, startRequest can indirectly call itself (via Resource.fetchBlob).

See the following call stack:
image
@tephenavies tephenavies mentioned this issue Sep 16, 2019
Merged
@fredj
Copy link
Contributor

fredj commented Jan 14, 2020

@steve9164, @kring can this issue be closed?

@kring
Copy link
Member

kring commented Jan 15, 2020

Yes, thank you @fredj!

@kring kring closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fredj @kring @tephenavies