Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ol-cesium chrome 76: too many errors #8105

Closed
edejin opened this issue Aug 25, 2019 · 6 comments · Fixed by #8534
Closed

ol-cesium chrome 76: too many errors #8105

edejin opened this issue Aug 25, 2019 · 6 comments · Fixed by #8534

Comments

@edejin
Copy link

edejin commented Aug 25, 2019

After chrome update:

256[.WebGL-0x2588fcac5300]GL ERROR :GL_INVALID_OPERATION : glDrawElements: GL_BLEND with floating-point color attachments requires the EXT_float_blend extension
7796ee5f-aab2-46bf-8f30-340669acc40a:1 WebGL: too many errors, no more errors will be reported to the console for this context.

And no features on screen.
Before Chrome 76 everything works fine.
Cesium 1.60.0
Is it chrome, ol-cesium or cesium bug?

@OmarShehata
Copy link
Contributor

Do you have a link to an example that reproduces this issue? Do the examples on Sandcastle load for you?

https://cesiumjs.org/Cesium/Apps/Sandcastle/index.html

This sounds like it could be this issue, which was a bug in Chrome #7798 (comment).

Can you try running Chrome Canary 77 to see if the issue is fixed there?

@edejin
Copy link
Author

edejin commented Aug 27, 2019

Thank you!

Do you have a link to an example that reproduces this issue?

No, because it's too big and confidential.

Do the examples on Sandcastle load for you?

https://cesiumjs.org/Cesium/Apps/Sandcastle/index.html

Yes, it's work fine.

This sounds like it could be this issue, which was a bug in Chrome #7798 (comment).

Can you try running Chrome Canary 77 to see if the issue is fixed there?

In Chrome 77 everything works fine.

@edejin edejin closed this as completed Aug 27, 2019
@thw0rted
Copy link
Contributor

thw0rted commented Nov 4, 2019

I've started seeing warnings about EXT_float_blend lately. In Firefox 70, the message is

Error: WebGL warning: drawElements: Using format enabled by implicitly enabled extension: EXT_float_blend. For maximal portability enable it explicitly.

Should I open a new issue? I get the warning when viewing the "Billboards" Sandcastle demo.

@thw0rted
Copy link
Contributor

thw0rted commented Nov 4, 2019

Also, I started seeing "Error: WebGL warning: generateMipmap: Tex image TEXTURE_2D level 0 is incurring lazy initialization." I don't know if they're related. If I don't hear anything here soon I'll open a new issue for both warnings at once.

@OmarShehata
Copy link
Contributor

@thw0rted there's some discussion here about that extension: #7798 (comment)

My comment there links to where the extensions are requested in the source code. Kai's comment here #7798 (comment) mentions there was a spec change and that extension now needs to be requested explicitly. Can you see if adding it fixes the warning? And if so open a PR?

And if the other warning is still there, I think that would be a separate issue if you can reproduce it in Sandcastle.

@thw0rted
Copy link
Contributor

thw0rted commented Nov 5, 2019

Your link points to a set of lines in the master branch but it looks like the file has changed significantly since May. I set a breakpoint in my browser's devtools and called getExtension(gl, ["EXT_float_blend"]) on L240 in the current Context.js and the warning went away. It looks like the presence of all the extensions that are requested are exposed on the Context object via a getter so it would seem a bit weird to just call getExtension for this one thing and ignore the return result.

I can put together a PR but it seems like somebody with more knowledge of the internals than I have might want to look into the implications of failing to get the extension -- is there a fallback path in a renderer somewhere that should be activated when the extension is missing? Also, would there be further implications in Chrome, on mobile, etc? That thread you linked made it sound more complicated than just adding this one line.

Also: I opened #8360 to track the other warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants