Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Test Failure - Scene/Cesium3DTileset tile expires #7895

Open
hpinkos opened this issue Jun 3, 2019 · 3 comments
Open

Edge Test Failure - Scene/Cesium3DTileset tile expires #7895

hpinkos opened this issue Jun 3, 2019 · 3 comments

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Jun 3, 2019

Scene/Cesium3DTileset tile expires
Expected -0.21600000000034924 to equal epsilon 0, 0.1.

http://localhost:8080/Specs/SpecRunner.html?spec=Scene%2FCesium3DTileset%20tile%20expires

@sanjeetsuhag
Copy link
Contributor

sanjeetsuhag commented Oct 3, 2022

This came up again in the 1.98 release. Sometimes it runs fast enough, other times not.

@jjhembd
Copy link
Contributor

jjhembd commented Jan 2, 2023

I get this error on my local machine. Can we simply increase the tolerance?

The problem code is:

          // Check that expireDuration and expireDate are correctly set
          const expireDate = JulianDate.addSeconds(
            JulianDate.now(),
            5.0,
            new JulianDate()
          );
          expect(
            JulianDate.secondsDifference(tile.expireDate, expireDate)
          ).toEqualEpsilon(0.0, CesiumMath.EPSILON1);

The errors I have seen are all smaller than 1. Replacing CesiumMath.EPSILON1 with 1.0 should be enough.

@ggetz
Copy link
Contributor

ggetz commented Jan 3, 2023

I think we may have more control of the order of execution here after #10909. If not, I think increasing the tolerance should be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants