-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imagery stops being requested. #7817
Comments
@kring any ideas here? |
@jfrancis537 Do you also see this issue in Sandcastle? https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/ |
I can't find a way to reproduce it in Sandcastle because I don't have an imagery set located outside of our closed network, but I think I found the source of the issue / a workaround. We use a UrlTemplateImageryProvider which makes a call to the server which would look up the image on the filesystem and return it as Content-Type jpeg.
Given that our imagery is incomplete, if the image doesn't exist, we return an HttpResponse with a status code of 204 No content. Once one of those is received in the browser, the imagery stops loading. However If the status code is changed to 404, the imagery continues to load as expected. |
It doesn't appear as though the actual content matters. Returning a 200 with a text/plain, still works as expected. After further testing it only appears to do this with the 204 response. |
That's very odd, I can't think of why a 204 would be different from an invalid-image 200. Is there a proper |
Neither has that header. |
@jfrancis537 just to rule out ImageBitmap as the culprit, can you add the snippet in #7735 at the top of your code before requesting any imagery and see if the issue still happens? |
Adding that snippet does make the issue go away. |
@jfrancis537 can you check if this issue is still present with the latest CesiumJS? I made a fix here #7914 that might have resolved this. |
Yep, it fixed it. |
After updating to the latest version of cesium I noticed that imagery will stop loading, http requests for the imagery are no longer going out.
I did notice that my event handler on my imageryProvider.errorEvent is no longer being called in 1.56.1+ vs 1.55 "throwing" a tile not found error.
Environment Details:
Our imagery is incomplete, we are missing various sections.
Our environment is offline.
Works Correctly in: Cesium 1.55
Version: Cesium 1.57 and 1.56.1
The text was updated successfully, but these errors were encountered: