-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect decoding of draco model with high quantization bit number #7471
Comments
Specifically I wouldn't be surprised if UNSIGNED_SHORT is hardcoded somewhere. |
@lilleyse Hi Sean, will this be fixed soon? if not, can you tell me where is possibly hardcoded, so that I can fix myself. |
When I set dequantizeInShader to false, the model is not distorted, and displays well. |
This also came up in CesiumGS/gltf-pipeline#511 |
Opened an issue in the Draco repo about whether it's possible to query the quantization bits without decoding to quantized form: google/draco#573 @sanjeetsuhag and I talked offline - if there's no way to do it in the API, we'll need to dequantize in our own code. |
@lilleyse Has this bug been fixed on the latest Cesium? |
@Ben-Mack, no, still an open issue |
Came up again in #10516 |
Came up again in #10977 |
Fixed in #10979 |
This was reported by Chris Wang on the forum.
The glTF file attached in this post was encoded with the following Draco parameters:
And renders incorrectly in Cesium. Here's what it looks like in Bablyon:
And in CesiumJS:
@lilleyse believes this might be because the quantization is hardcoded in a few places in our Draco decoding.
The text was updated successfully, but these errors were encountered: