Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary import? #6456

Closed
puckey opened this issue Apr 17, 2018 · 1 comment
Closed

Necessary import? #6456

puckey opened this issue Apr 17, 2018 · 1 comment

Comments

@puckey
Copy link
Contributor

puckey commented Apr 17, 2018

I noticed Source/Scene/Globe.js is importing Material.js but isn't using it in the code aside from referring to it in the doc comments. This is causing lots of code to be included in my builds unnecessarily...

Would a pull request removing this import be welcome?

@hpinkos
Copy link
Contributor

hpinkos commented Apr 17, 2018

Thanks @puckey, yes it looks like that can be removed. Feel free to open a PR removing that and any other unnecessary requires. We usually go through maybe once a year and clean that up, but it's been a little while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants