Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to credit some sources properly in Cesium. #6280

Closed
mramato opened this issue Feb 27, 2018 · 3 comments
Closed

Impossible to credit some sources properly in Cesium. #6280

mramato opened this issue Feb 27, 2018 · 3 comments

Comments

@mramato
Copy link
Contributor

mramato commented Feb 27, 2018

Currently, all credits get mashed together into a single list, but this makes it hard to properly credit some sources. For example, Creative Commons Attribution 4.0 International (CC BY 4.0) requires a link to the CC 4.0 license, but there's no way via credits to indicate which data this license applies to without repeating information across Credits.

For example let's say I have a data source Foo Imagery, that requires attribution to both Bar.inc and CC 4.0. I also need to link to both. Right now I would be forced to write

This can get pretty crowded when you have multiple data sources and many attributions are much more elaborate. I would much rather write:

  • Foo Imagery (includes part of data X and Y) provided by Bar.inc and licensed under CC 4.0

The best idea I have for fixing this is allowing HTML credits instead of just text. OpenLayers does this already, but all credits are manually added by the user. Since we support server-side credits, we probably need to sanitize the credit using https://www.npmjs.com/package/xss or similar.

@hpinkos
Copy link
Contributor

hpinkos commented Feb 27, 2018

Other libraries like leaflet and openlayers have HTML credits. I think that's the way to go

@kring
Copy link
Member

kring commented Jun 8, 2018

I believe this was fixed in #6331.

@hpinkos
Copy link
Contributor

hpinkos commented Jun 8, 2018

Yes, thanks @kring

@hpinkos hpinkos closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants