-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreditDisplay.addDefaultCredit can't be shown in the lightbox #6215
Comments
This was more-or-less by design, but it shouldn't be too hard to change |
@hpinkos Is there a particular reason not to show additional credits in the lightbox? Someone on the forum was looking to do just that. If it's on purpose, we should at least clarify in the docs. |
We just made the assumption that a default credit is probably something important and should always show on screen. Like I said, I don't think it will be too hard to change it though. |
Maybe I'm just confused but what exactly is the difference between |
|
Our documentation on this is pretty sparse. We should probably consider changing the names of these functions and expanding their documentation (as well as adding better summary documentation to CreditDisplay overall). Also sounds like I can't imagine end users ever calling |
If we're cleaning this up, we should probably make |
I think it makes sense that |
I think it does make sense to expose it at a higher level though, we do this elsewhere. So a getter property like |
|
@shunter good point, the name is still terrible though :) |
Just 👍 here that we should expose |
Hello, I'd like to add some custom credits in the lightbox. I don't need them in the credits container. Neither Moreover, the credit display is only accessible through |
CreditDisplay.addDefaultCredit
doesn't takeCredit.showOnScreen
into account, butCreditDisplay.addCredit
does.From the forum: https://groups.google.com/forum/#!topic/cesium-dev/3qiLgbwJCZI
The text was updated successfully, but these errors were encountered: