Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KHR_technique_webgl extension for glTF #6149

Closed
pjcozzi opened this issue Jan 24, 2018 · 4 comments
Closed

Support KHR_technique_webgl extension for glTF #6149

pjcozzi opened this issue Jan 24, 2018 · 4 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 24, 2018

@ggetz @lilleyse for after Draco, #5120

Please track and participate as needed in the spec discussion here: KhronosGroup/glTF#1217

Update both Cesium and gltf-pipeline.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Sep 26, 2018

@ggetz OK to close this?

@ggetz ggetz closed this as completed Sep 26, 2018
@OmarShehata
Copy link
Contributor

@ggetz it looks like the extension was renamed from KHR_technique_webgl to KHR_techniques_webgl at some point, (it doesn't have the s in 1.49) but I don't see a breaking change announcement for it in changes.md.

This is breaking some people's tilesets (see forum thread). Should we just check for both or should we have had a deprecation period? I'm not sure what all went into this rename so apologies if I'm missing some context here.

@ggetz
Copy link
Contributor

ggetz commented Oct 11, 2018

The extension name itself changed after he initial draft. They should update their tilesets since it's no longer valid. I think checking ad throwing a oneTimeWarning which we eventually remove would work. @lilleyse sound good?

@OmarShehata
Copy link
Contributor

I just spoke with @lilleyse offline, and it sounds like even though it was in 1.49, it was never officially supported, and that it's not just a naming change, that the old tilesets wouldn't really work out of the box, so it shouldn't be something we can support.

Perhaps the best course of action here is to update those old tilesets with obj2gltf ? (Assuming the source obj still exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants