Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NYC 3D Tiles demo doesn't work in 2D or CV #5955

Open
mramato opened this issue Nov 1, 2017 · 12 comments
Open

NYC 3D Tiles demo doesn't work in 2D or CV #5955

mramato opened this issue Nov 1, 2017 · 12 comments

Comments

@mramato
Copy link
Contributor

mramato commented Nov 1, 2017

http://localhost:8080/Apps/Sandcastle/index.html?src=3D%20Tiles%20Feature%20Picking.html&label=All

In 2D, buildings are way off. In CV they are off and/or crooked depending on if you visited the tile in 3D mode first.

2D
image

CV

image

@mramato
Copy link
Contributor Author

mramato commented Nov 1, 2017

CC @lilleyse @pjcozzi

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 15, 2017

Also, switch back to 3D and only a subset of the buildings stream in. Perhaps there is an issue with what mode the scene is in when a tile is loaded?

image

@mramato
Copy link
Contributor Author

mramato commented Dec 15, 2017

Do we think this and #6056 have the same root cause?

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 15, 2017

Yes.

via @Vineg in #6056

We have a 3dTiles model which gets corrupted after switching to 2d mode and then back to 3d. Some DrawCommands seem to have wrong BoundingSphere center and not being rendered.
Can you take a look at https://github.com/AnalyticalGraphicsInc/cesium/blame/b0939bf96697ec8c51cc32b8b96c5ed79b94a71a/Source/Scene/Model.js#L3798
It seems that when we switch back to 3d, model._rtcCenter not gets switched back to _rtcCenter3D

@OmarShehata
Copy link
Contributor

Came up again on the forum:

In addition - i found that changing the view corrupts my data. this means, when I changed to 2d view and after that back to 3d view nothing will be displayed - "the data are lost"

@kteneyck
Copy link

Any update on these issues when switching to 2D with 3D Tiles loaded into Cesium? The only way we're going to be able to support 2D is to unload and reload any tilesets we have when switching views.

@lilleyse
Copy link
Contributor

@kteneyck we're actively working on this and other 2D bugs: #9934

@lilleyse
Copy link
Contributor

@j9liu can this be closed now that #10384 is merged?

@j9liu
Copy link
Contributor

j9liu commented May 31, 2022

yes, closing now!

@j9liu j9liu closed this as completed May 31, 2022
@mramato
Copy link
Contributor Author

mramato commented May 31, 2022

I was super excited about this but when I tried main it looks like 2D is still broken?

This is pretty obvious in Manhattan, but especially obvious around Central Park:

Screenshot_20220531_110746

@mramato mramato reopened this May 31, 2022
@j9liu
Copy link
Contributor

j9liu commented May 31, 2022

@mramato was this with enableModelExperimental: true added to the Cesium3DTileset constructor? The PR was implemented for ModelExperimental and it isn't used by default (yet!)

@mramato
Copy link
Contributor Author

mramato commented May 31, 2022

@j9liu No, it wasn't. But if that's the case then I'm not sure why we would close this until everything "just works". I would consider this issue as part of the final testing that should happen when ModelExperimental goes away and just becomes Model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants