Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve particle system memory management performance #5522

Open
pjcozzi opened this issue Jun 22, 2017 · 3 comments
Open

Improve particle system memory management performance #5522

pjcozzi opened this issue Jun 22, 2017 · 3 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 22, 2017

From #5212 (comment)

In the fireworks Sandcastle example, I would not expect this to be 10% of the profile?

image

and #5212 (comment)

The problem is the memory management again. Sometimes more particles are created than was estimated and they get removed later. This causes the number of commands from the billboard collection to change. For every new command, it generates the OIT shader and looks it up in the cache.

@hpinkos
Copy link
Contributor

hpinkos commented Jul 31, 2017

The Particle System Fireworks sandcastle demo won't load in Firefox for me, it says the web page is slowing down the browser. Is this why?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Aug 2, 2017

@hpinkos most likely not. It loads OK for me on Mac Firefox 54. Can you confirm this doesn't load for you with a clean build and clear cache in Firefox 54, check out the console, and then submit a new issue if it is a problem?

@hpinkos
Copy link
Contributor

hpinkos commented Aug 2, 2017

Okay, it worked after I cleared my cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants