Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Tiles scaling does not scale geometric error #5330

Closed
mramato opened this issue May 16, 2017 · 3 comments · Fixed by #8182
Closed

3D Tiles scaling does not scale geometric error #5330

mramato opened this issue May 16, 2017 · 3 comments · Fixed by #8182

Comments

@mramato
Copy link
Contributor

mramato commented May 16, 2017

When setting a scale transform on the root tile in order to scale a 3D Tileset, bad things happen. The tileset may draw, but at the wrong resolution and it may also disappear completely when it should take up the whole screen. @likangning93 thinks the problem is that Cesium is not taking the scale transform into account when computing the final client geometric error, leading to incorrect tile selection.

@lilleyse
Copy link
Contributor

If we decide to address this in Cesium, we should also update the spec:

From tile.schema.json

A floating-point 4x4 affine transformation matrix, stored in column-major order, that transforms the tile's content, i.e., its features and content.boundingVolume, and boundingVolume and viewerRequestVolume from the tile's local coordinate system to the parent tile's coordinate system, or tileset's coordinate system in the case of the root tile. transform does not apply to geometricError nor does it apply any volume property when the volume is a region, which is defined in EPSG:4326 coordinates.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 18, 2017

I probably wrote that part of the spec, but it is not going to work. Two options:

  • Explicitly disallow scale as part of the spec. It will make the client a bit easier to implement if they actually follow the spec. Cesium could still expose its own scale/transform.
  • Allow scale in the spec - including the GE - and fix Cesium, which I do not think will be hard unless I am missing something.

I would go with 2.

@mramato
Copy link
Contributor Author

mramato commented Sep 17, 2018

Ran into this again playing around with ion's new tileset location tool, which also allows scaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants