Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify difference between GoogleEarthImageryProvider and GoogleEarthEnterpriseImageryProvider #5310

Closed
hpinkos opened this issue May 11, 2017 · 2 comments
Labels
category - doc cleanup good first issue An opportunity for first time contributors

Comments

@hpinkos
Copy link
Contributor

hpinkos commented May 11, 2017

From @thw0rted in #5189

The thread here was very helpful in understanding the difference between the GE provider and the GEE provider, but this clarification is sorely lacking in the documentation. Since both providers actually talk to GEE (and not the public GE server), maybe in a future release it would be helpful to merge the two and provide a 2D/3D mode switch? That would clarify the intent.

@mramato
Copy link
Contributor

mramato commented May 11, 2017

Thanks for the reminder, I meant to mention this in the original PR. I think a rename of the original class to mention Maps (i.e. GoogleEarthEnterpriseMapsProvider) and @link in the jsDoc for both that clearly explain the differences should be a good, low-impact way of handling this.

@lilleyse
Copy link
Contributor

lilleyse commented Jun 5, 2017

Fixed in #5399

@lilleyse lilleyse closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - doc cleanup good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

4 participants