Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw debugging errors in the 3D Tiles Sandcastle demos #5158

Closed
lilleyse opened this issue Mar 27, 2017 · 4 comments
Closed

Throw debugging errors in the 3D Tiles Sandcastle demos #5158

lilleyse opened this issue Mar 27, 2017 · 4 comments

Comments

@lilleyse
Copy link
Contributor

For development/debugging purposes it would be helpful to see when errors occur when loading tileset.json or individual tiles while in the Sandcastle demos, as the current behavior just leaves an empty globe / empty tile space.

Checking for tileset.json errors is pretty easy, but checking for tile errors is more difficult as the readyPromise is not easily accessible from the outside. Would it be worth supporting a debugging event in Cesium3DTileset like tileFailed to look for these types of errors in the Sandcastle demos?

This will help save a lot of time when debugging invalid tiles.

@lilleyse
Copy link
Contributor Author

lilleyse commented May 24, 2017

Example case where this would help: #5353

@mramato
Copy link
Contributor

mramato commented May 24, 2017

I think a tileFailed event makes a lot of sense, do terrain and imagery already do something similar? We should make sure we have a holistic approach so that the architecture/API makes sense from the outside.

This was referenced May 24, 2017
@lilleyse
Copy link
Contributor Author

do terrain and imagery already do something similar

I think so, TileProviderError.handleError does something like this.

@lilleyse
Copy link
Contributor Author

Fixed in #6088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants