Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positive time offset doesn't work at stop time #4949

Closed
emackey opened this issue Feb 3, 2017 · 1 comment
Closed

Positive time offset doesn't work at stop time #4949

emackey opened this issue Feb 3, 2017 · 1 comment
Labels
good first issue An opportunity for first time contributors type - bug

Comments

@emackey
Copy link
Contributor

emackey commented Feb 3, 2017

In EntityView.js#L57, a small positive time offset of 0.001 seconds is used to get a tiny position delta, used to approximate a velocity near that moment in time. The time offset does not work for the last 0.001 seconds of playback in the scene, if the objects don't have position data available past the stop time. This can cause the camera to flip over, for example if it is tracking a GEO satellite and the user moves the timeline to the stop time.

One fix could be to test if the 0.001 offset failed, and attempt a -0.001 offset instead, negating the resulting vector. I don't think this would be much of a performance hit because it would be a code path only used when the current position is available but a small positive delta position failed. Can anyone think of other downsides to this possible fix?

@emackey emackey added good first issue An opportunity for first time contributors type - bug labels Feb 3, 2017
@mramato
Copy link
Contributor

mramato commented Feb 3, 2017

Can anyone think of other downsides to this possible fix?

I thought we were actually already doing this (I'm pretty sure we do it elsewhere when we use finite differencing). So good with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An opportunity for first time contributors type - bug
Projects
None yet
Development

No branches or pull requests

2 participants