Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MIDDLE_DOUBLE_CLICK and RIGHT_DOUBLE_CLICK events #4911

Closed
lilleyse opened this issue Jan 23, 2017 · 4 comments
Closed

Remove MIDDLE_DOUBLE_CLICK and RIGHT_DOUBLE_CLICK events #4911

lilleyse opened this issue Jan 23, 2017 · 4 comments
Labels
good first issue An opportunity for first time contributors

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Jan 23, 2017 •
edited
Loading

Deprecation PR: #4910
@smills2929
Copy link

Is the LEFT_DOUBLE_CLICK event being removed?

@mramato
Copy link
Contributor

mramato commented Jan 24, 2017

I don't think it makes sense to remove LEFT_DOUBLE_CLICK. it's used internally and is pretty standard. @emackey exactly what were you thinking here?

@lilleyse
Copy link
Contributor Author

I left a note about that here: #4910 (comment)

It'll probably be best just to deprecate right and middle.

@emackey
Copy link
Contributor

emackey commented Jan 24, 2017

Yes, deprecate only right and middle. Keep left, but remember that there should always be a touch-friendly alternative to double-left-click. For example, for trackedEntity, you can double-left-click the entity, or you can touch the entity and then touch the camera button on the InfoBox.

@lilleyse lilleyse changed the title Remove deprecated double click events Remove MIDDLE_DOUBLE_CLICK and RIGHT_MIDDLE_CLICK events Jan 24, 2017
@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Jan 24, 2017
@emackey emackey changed the title Remove MIDDLE_DOUBLE_CLICK and RIGHT_MIDDLE_CLICK events Remove MIDDLE_DOUBLE_CLICK and RIGHT_DOUBLE_CLICK events Jan 27, 2017
@lilleyse lilleyse mentioned this issue Mar 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pjcozzi @lilleyse @emackey @mramato @smills2929