Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sandcastle load time #4906

Closed
pjcozzi opened this issue Jan 23, 2017 · 4 comments
Closed

Improve Sandcastle load time #4906

pjcozzi opened this issue Jan 23, 2017 · 4 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 23, 2017

By using the built Cesium.js for the deployed version.

See #4889 (comment)

@emackey
Copy link
Contributor

emackey commented Jan 23, 2017

In the interest of avoiding thrashing, it's worth noting that we went the other direction (from pre-built to separate requires) back in #2164. We did this so users didn't need to run combine before running Sandcastle. Maybe we could look for the built version for speed, and fall back on the requires for convenience? That seems like a lot of dependency logic to inject just to get a version number and autocomplete working.

@emackey
Copy link
Contributor

emackey commented Jan 23, 2017

+1 for improving load times though!

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 23, 2017

@emackey I'm suggesting that we basically just have this optimization for the released version. I'm open to other variations, but do not want to require building often.

@emackey
Copy link
Contributor

emackey commented Jan 23, 2017

Ah, release Sandcastle should use a built copy of Cesium, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants