Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax error in master according to Eclipse #4796

Closed
emackey opened this issue Jan 2, 2017 · 1 comment
Closed

Syntax error in master according to Eclipse #4796

emackey opened this issue Jan 2, 2017 · 1 comment
Labels
cleanup good first issue An opportunity for first time contributors priority - next release

Comments

@emackey
Copy link
Contributor

emackey commented Jan 2, 2017

Eclipse Luna (configured as per the official Cesium Contributor's Guide) shows a red syntax error in master on Check.js#L91 saying:

Syntax error on token "function", Identifier expected

This error is repeated several more times in CheckSpec.js.
@pjcozzi pjcozzi added cleanup good first issue An opportunity for first time contributors labels Jan 2, 2017
@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2017

This passes JSHint, but I think we should still rename it; I have used func elsewhere to avoid this.

@erikmaarten can you please update?

@erikmaarten erikmaarten mentioned this issue Jan 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue An opportunity for first time contributors priority - next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjcozzi @emackey