Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polylines with custom model matrix draw incorrectly in 2D and Columbus View #474

Closed
mramato opened this issue Jan 21, 2013 · 1 comment
Closed

Comments

@mramato
Copy link
Contributor

mramato commented Jan 21, 2013

PolylinePipeline.wrapLongitude currently takes an ellipsoid and array of positions, but the positions are always assumed to be in earth-fixed. If you create a Polyline collection and assign the modelMatrix property (for example to draw inertial orbit paths), we incorrectly pass non earth-fixed positions to PolylinePipeline.wrapLongitude, causing incorrect results and horizontal lines that run across the entire map. The simple (but slow) fix is to have Polyline translate each of its positions to earth-fixed using modelMatrix before calling PolylinePipeline.wrapLongitude. Since this would probably have a large impact on performance, I hope we can figure out a better way to do it.

This may not even be that big of a deal for the time being, since we will most likely always draw earth-fixed paths in 2D and Columbus view, but ultimately we want that to be a user option.

@bagnell bagnell mentioned this issue Feb 2, 2013
@bagnell
Copy link
Contributor

bagnell commented Feb 4, 2013

This is fixed in the above pull request. Closing.

@bagnell bagnell closed this as completed Feb 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants