Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geocoder lon/lat bug #4713

Closed
hpinkos opened this issue Dec 2, 2016 · 5 comments
Closed

Geocoder lon/lat bug #4713

hpinkos opened this issue Dec 2, 2016 · 5 comments
Labels
good first issue An opportunity for first time contributors type - bug

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Dec 2, 2016

Reported on the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/pbt7SSTR6CY

Type 39N 75W in geocoder - Cesium takes you to Philadelphia and replaces the text in geocoder with 39, -75
But if you type 39, -75 you end up in Antarctic at 39E 75S

@mramato mramato mentioned this issue Dec 2, 2016
9 tasks
@hpinkos
Copy link
Contributor Author

hpinkos commented Dec 2, 2016

@erikmaarten could you look at this when you're making other improvements to the geocoder during the code sprint?

@mramato
Copy link
Contributor

mramato commented Dec 2, 2016

So we have special code that handles numbers-only entries that uses Cesium lon/lat/alt order to zoom instead of Bind. I'm guessing 39N 75W ends up using Bing for the geocode while 39, -75 uses Cesium. This is probably easy to change, but I'm not sure how we really want it to work. I'm 90% sure we will end up leaving it as-is, since it's imperfect input anyway, but I'm open to ideas.

@mramato
Copy link
Contributor

mramato commented Dec 2, 2016

It's also possible that Bing didn't handle numbers when we added the Cesium-specific code path, we could probably go Bing-only if it now fits the bill.

@hpinkos
Copy link
Contributor Author

hpinkos commented Dec 2, 2016

yep, i'm sure that's exactly what's happening. Bing is geocoding it and returning lat/lon and then if you hit enter again it goes into our custom code that does lon/lat

@erikmaarten
Copy link
Contributor

I'll change the geocoder service for lat/long take this into account after #4723 has been merged.

@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Dec 20, 2016
@hpinkos hpinkos closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An opportunity for first time contributors type - bug
Projects
None yet
Development

No branches or pull requests

4 participants