Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdbush causes webpack warning #4418

Closed
chris-cooper opened this issue Oct 10, 2016 · 0 comments
Closed

kdbush causes webpack warning #4418

chris-cooper opened this issue Oct 10, 2016 · 0 comments

Comments

@chris-cooper
Copy link
Contributor

As previously reported with earcut, kdbush is producing the following warning with webpack.

./~/cesium/Source/ThirdParty/kdbush.js
Critical dependencies:
1:479-486 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
 @ ./~/cesium/Source/ThirdParty/kdbush.js 1:479-486

I haven't noticed any runtime issues yet, but it would be good to have a better strategy for these third party dependencies such as pulling in the un-built source via an npm dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants