Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VR renders the same image for both eyes #3909

Closed
jmgomezpoveda opened this issue May 11, 2016 · 10 comments
Closed

VR renders the same image for both eyes #3909

jmgomezpoveda opened this issue May 11, 2016 · 10 comments

Comments

@jmgomezpoveda
Copy link

When enabling the VR mode (useWebVR / vrButton), two images are rendered side by side.

http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=Cardboard.html&label=

I would expect these images to be slightly different, simulating the position of the eyes to create the 3D effect. However, the images I see are exactly the same (subtracting them in GIMP gives a completely black image).

vr
vr2

Tested with Firefox and Chromium.

@mramato
Copy link
Contributor

mramato commented May 11, 2016

@bagnell we should probably look at this for the next release.

@mramato
Copy link
Contributor

mramato commented May 11, 2016

Thanks for the report @jmgomezpoveda!

@pjcozzi
Copy link
Contributor

pjcozzi commented May 26, 2016

@bagnell can you look at this in time for the release next week?

@pjcozzi
Copy link
Contributor

pjcozzi commented May 31, 2016

@bagnell are you able to look at this for the 1.23 release tomorrow?

@bagnell
Copy link
Contributor

bagnell commented Jun 1, 2016

The images are different for objects close to the camera so you wouldn't see anything different in those two example screen shots. I'll push out the default near plane and add parameters to make it adjustable. It won't make the 1.22 release, but will make the 1.23.

@bagnell
Copy link
Contributor

bagnell commented Jun 9, 2016

Here's an example with the camera close to the basket of a hot air balloon. The rendering for each eye:
vr0
vr1
And here's the diff (the pixels different are pink):
vrdiff

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 23, 2016

@bagnell this is labeled 1.23, but do we really need to do anything for this release?

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 4, 2016

OK to close this?

@bagnell
Copy link
Contributor

bagnell commented Nov 4, 2016

No, it doesn't render the same for both eyes when you have things close to the viewer, so I want to add options to push that distance out.

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 2, 2017

@jmgomezpoveda thanks again for submitting this issue. This was fixed in #5917. Please let us know if you build something cool with Cesium and VR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants