Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EllipseGeometryLibrary's computeEllipsePositions misses critical points #3078

Closed
nmschulte-aviture opened this issue Oct 14, 2015 · 0 comments · Fixed by #3326
Closed

EllipseGeometryLibrary's computeEllipsePositions misses critical points #3078

nmschulte-aviture opened this issue Oct 14, 2015 · 0 comments · Fixed by #3326

Comments

@nmschulte-aviture
Copy link
Contributor

Because the logic for computing the positions about the ellipse works by computing the "north" half of the ellipse (by computing the "west" half and then its reflection) and then its reflection, with low granularities, say a granularity of PI_OVER_TWO (to retrieve the four critical points, 0, pi/2, pi, 3pi/4), all of the resolution is focused around the west/east points, and none about the north/south points. (In fact, with PI_OVER_TWO, the two east/west points are duplicated in the calculation).

You can see this visually in the screenshot from @bagnell's work here re: granularity:
#2283 (comment)

I'm wondering if simply adding the calculation for the critical points would be enough to resolve this? Perhaps changing the math to mirror about the 45, 135, 225 and 315 degree angles (rather than the current 0/90/180/270) would help in conjunction w/ adding the critical points. This seems like it would always ensure an accurate representation of the ellipse from the computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant