Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeButtonViewModel uses deprecated camera functionality #2437

Closed
kring opened this issue Jan 29, 2015 · 5 comments
Closed

HomeButtonViewModel uses deprecated camera functionality #2437

kring opened this issue Jan 29, 2015 · 5 comments

Comments

@kring
Copy link
Member

kring commented Jan 29, 2015

The direction and up parameters to Camera.flyTo have been deprecated but they're still used in HomeButtonViewModel:

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Widgets/HomeButton/HomeButtonViewModel.js#L58

@mramato
Copy link
Contributor

mramato commented Jan 29, 2015

This is already fixed in the entity-zoom branch. But we can leave this open until its in master.

@emackey
Copy link
Contributor

emackey commented Jan 29, 2015

I know we're swamped, but it seems like very bad form to ship a release that prints the deprecation warning for users that click Home. The average user won't know why they're seeing the message, and it makes many Sandcastle demos appear broken when you look at the console.

@mramato
Copy link
Contributor

mramato commented Jan 29, 2015

It's not going to ship, entity-zoom (and related branches) will be going into master tomorrow

@kring
Copy link
Member Author

kring commented Jan 29, 2015

Ok, thanks guys!

@mramato
Copy link
Contributor

mramato commented Feb 3, 2015

Fixed in #2315

@mramato mramato closed this as completed Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants