Make render/pick tests use the scene

[pjcozzi]

Most old low-level primitive rendering tests that use render directly can be updated to use the real Cesium Scene, like DebugModelMatrixPrimitiveSpec does, which makes the tests more realistic and more concise.

[pjcozzi]

When the glTF branch is merged, they can also use renderForSpecs introduced in 4c28451.

[pjcozzi]

Billboards/Labels were updated in #2669

[pjcozzi]

@lilleyse after #817, we'll start chipping away at this (not all at once, we'll split it into several pull requests). To see the files that need to be updated, search in all files for Specs/render. An easy file to start with is probably ViewportQuadSpec.js. Look at DebugModelMatrixPrimitiveSpec.js for a simple example.

[pjcozzi]

@lilleyse let's start with ViewportQuadSpec and GroundPrimitiveSpec today.

• DebugAppearanceSpec
• EllipsoidPrimitiveSpec
• EllipsoidSurfaceAppearanceSpec
• GeometryRenderingSpec
• GlobeSpec
• GlobeSurfaceTileProviderSpec
• GroundPrimitiveSpec // Just remove the reference; it is not used
• MaterialAppearanceSpec
• MaterialSpec
• PerInstanceColorAppearanceSpec
• PolygonSpec
• PolylineCollectionSpec
• PolylineColorAppearanceSpec
• PolylineMaterialAppearanceSpec
• PrimitiveCollectionSpec
• PrimitiveCullingSpec
• PrimitiveSpec
• RectanglePrimitiveSpec
• SceneSpec // Not sure we'll do this one
• ViewportQuadSpec

[lilleyse]

Should all these pull requests go into their own branch, like renderer-refactor in #640 ?

[pjcozzi]

Yes, one branch per pull request. The branch may have one or more refactored specs.

[lilleyse]

I mean should the master repo have a branch called spec-refactor, like how I made my renderer pull requests go into renderer-refactor?

[pjcozzi]

Ah, sorry. No, it is fine to open the pull request directly into master.

[lilleyse]

GlobeSpec was updated in 8f20940.

[pjcozzi]

@lilleyse can you also update the new tests in PrimitiveSpec.js in the 3d-tiles branch?

[runJsHint] Specs/Scene/PrimitiveSpec.js: line 402, col 9, 'frameState' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 403, col 9, 'frameState' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 404, col 9, 'us' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 404, col 28, 'frameState' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 406, col 9, 'ClearCommand' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 409, col 9, 'render' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 409, col 25, 'frameState' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 439, col 39, 'frameState' is not defined.

[pjcozzi]

@lilleyse can we close this? If not, what is left? I took a quick look at SceneSpec and I'm not sure that we need to make any changes there. Do we still need to update tests to use renderForSpecs?

[lilleyse]

@lasalvavida is working on a final cleanup PR for any files not included on this list, so until that is ready we can leave this open.

[lilleyse]

Thanks for the great work on this @lasalvavida.