Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fog color is too dark #12262

Open
jjspace opened this issue Oct 25, 2024 · 2 comments
Open

Fog color is too dark #12262

jjspace opened this issue Oct 25, 2024 · 2 comments

Comments

@jjspace
Copy link
Contributor

jjspace commented Oct 25, 2024

While working on #12248 I noticed the fog color overall seems too dark compared to other platforms like Google Earth. I would expect the colors to more closely match the light white/yellow at the base of the atmosphere.

2024-10-25_16-24
2024-10-25_16-27

This gets even worse/more obvious if you crank up the density
2024-10-25_16-30

Looking back at some older fog related issues it seems like it wasn't always this way so hopefully it's an easy fix that was just missed somewhere along the way

From #8454

or

@ggetz
Copy link
Contributor

ggetz commented Oct 25, 2024

I think I have a fix for this started in https://github.com/CesiumGS/cesium/compare/atmopshere-scattering-fx?expand=1

Basically ground atmosphere scattering is not using the same amount of light color as the sky, plus the alpha value was not being correctly computed.

@jjspace
Copy link
Contributor Author

jjspace commented Nov 1, 2024

As discussed in #12248 when the issues with the fog darkness are fixed we should increase the default visualDensityScalar so fog is more visually impactful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants