Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug wireframe index overflow in Model #10529

Open
ptrgags opened this issue Jul 8, 2022 · 0 comments
Open

debug wireframe index overflow in Model #10529

ptrgags opened this issue Jul 8, 2022 · 0 comments

Comments

@ptrgags
Copy link
Contributor

ptrgags commented Jul 8, 2022

in This Sandcastle, I tried rendering Cesium OSM buildings with debugWireframe: true. It mostly works but one building here looks like it exploded

image

I had a very similar problem when working on #10506, it was due to that one building having very close to 65535 vertices, so the re-indexing caused it to overflow. The fix is to upgrade to a Uint32Array if the new length is above the limit. See these lines in PrimitiveOutlineGenerator.js for more details.

CC @j9liu

@j9liu j9liu changed the title debug wireframe index overflow in ModelExperimental debug wireframe index overflow in Model Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants