Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues when rendering OSM buildings with ModelExperimental #10338

Closed
ptrgags opened this issue Apr 29, 2022 · 4 comments
Closed

Rendering issues when rendering OSM buildings with ModelExperimental #10338

ptrgags opened this issue Apr 29, 2022 · 4 comments

Comments

@ptrgags
Copy link
Contributor

ptrgags commented Apr 29, 2022

In This forum thread, a Sandcastle was presented to demonstrate incorrect rendering.

I think I see 3 problems here:

  1. OSM buildings use the CESIUM_primitive_outline glTF extension, this is not yet implemented. This was mentioned in 3D Tiles Next CesiumJS Roadmap #9520
  2. It seems like the lighting is using a constant normal (which could be the default normal in the model material?
    image
  3. The dropdown option "Color by Distance to Selected Location" breaks the shader. Might have to do with fetching metadata. Note that OSM buildings uses the batch table hierarchy extension, not sure if that has an impact here.
    image
@j9liu
Copy link
Contributor

j9liu commented Jun 13, 2022

Making a note: when we add support for CESIUM_primitive_outline can we test if the bug in #10452 comes up?

@ptrgags
Copy link
Contributor Author

ptrgags commented Jun 28, 2022

Today I discovered that the problem isn't a constant normal (Cesium OSM buildings do have normals!) but that the material is rendering as too shiny, that's just the IBL reflecting the sky. It is more noticeable compared to the old Model, not sure why.

And I'm currently working on CESIUM_primitive_outline support in ModelExperimental. (not quite ready for a PR yet, but I can at least render outlines locally!). The lighting looks a bit off, but it's a lot better than before!
image.

@kring
Copy link
Member

kring commented Jun 30, 2022

Yeah Cesium for Unreal renders the buildings as crazy shiny, too. I think the problem is that I chose the material parameters in Cesium OSM Buildings based on the old Model code, and that didn't fully capture the shine I was putting on it.
image

@ptrgags
Copy link
Contributor Author

ptrgags commented Jul 7, 2022

Now that #10506 is merged, I'm closing this too. Here's a screenshot from the current main:

image

@ptrgags ptrgags closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants