From 235e15ecea88f090bf1bc9e4c0c467742bfc2440 Mon Sep 17 00:00:00 2001 From: Alex Gallegos <39537389+argallegos@users.noreply.github.com> Date: Mon, 22 Feb 2021 15:59:55 -0500 Subject: [PATCH 1/6] Remove deprecated enum from EasingFunction.js --- Source/Core/EasingFunction.js | 51 ----------------------------------- 1 file changed, 51 deletions(-) diff --git a/Source/Core/EasingFunction.js b/Source/Core/EasingFunction.js index 0893bbe22f60..ca537d660409 100644 --- a/Source/Core/EasingFunction.js +++ b/Source/Core/EasingFunction.js @@ -238,57 +238,6 @@ var EasingFunction = { BOUNCE_IN_OUT: Tween.Easing.Bounce.InOut, }; -Object.defineProperties(EasingFunction, { - /** - * Quadratic in. - * @memberof EasingFunction - * @type {EasingFunction.Callback} - * @constant - * @deprecated This enum has been deprecated and will be removed in Cesium 1.79. Use {@link EasingFunction.QUADRATIC_IN} instead. - */ - QUADRACTIC_IN: { - get: function () { - deprecationWarning( - "QUADRACTIC_IN", - "QUADRACTIC_IN is deprecated and will be removed in Cesium 1.79. Use QUADRATIC_IN instead." - ); - return Tween.Easing.Quadratic.In; - }, - }, - /** - * Quadratic out. - * @memberof EasingFunction - * @type {EasingFunction.Callback} - * @constant - * @deprecated This enum has been deprecated and will be removed in Cesium 1.79. Use {@link EasingFunction.QUADRATIC_OUT} instead. - */ - QUADRACTIC_OUT: { - get: function () { - deprecationWarning( - "QUADRACTIC_OUT", - "QUADRACTIC_OUT is deprecated and will be removed in Cesium 1.79. Use QUADRATIC_OUT instead." - ); - return Tween.Easing.Quadratic.Out; - }, - }, - /** - * Quadratic in then out. - * @memberof EasingFunction - * @type {EasingFunction.Callback} - * @constant - * @deprecated This enum has been deprecated and will be removed in Cesium 1.79. Use {@link EasingFunction.QUADRATIC_IN_OUT} instead. - */ - QUADRACTIC_IN_OUT: { - get: function () { - deprecationWarning( - "QUADRACTIC_IN_OUT", - "QUADRACTIC_IN_OUT is deprecated and will be removed in Cesium 1.79. Use QUADRATIC_IN_OUT instead." - ); - return Tween.Easing.Quadratic.InOut; - }, - }, -}); - /** * Function interface for implementing a custom easing function. * @callback EasingFunction.Callback From e847bf3dcd13ad3f93c12d1723e5fb9b923237f8 Mon Sep 17 00:00:00 2001 From: Alex Gallegos <39537389+argallegos@users.noreply.github.com> Date: Mon, 22 Feb 2021 16:28:09 -0500 Subject: [PATCH 2/6] Removed Cesium3DTileset.url from Cesium3DTileset.js --- Source/Scene/Cesium3DTileset.js | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/Source/Scene/Cesium3DTileset.js b/Source/Scene/Cesium3DTileset.js index f2c1e5377bf2..38534874652d 100644 --- a/Source/Scene/Cesium3DTileset.js +++ b/Source/Scene/Cesium3DTileset.js @@ -1165,25 +1165,6 @@ Object.defineProperties(Cesium3DTileset.prototype, { }, }, - /** - * The url to a tileset JSON file. - * - * @memberof Cesium3DTileset.prototype - * - * @type {String} - * @readonly - * @deprecated - */ - url: { - get: function () { - deprecationWarning( - "Cesium3DTileset.url", - "Cesium3DTileset.url has been deprecated and will be removed in CesiumJS 1.79. Instead, use Cesium3DTileset.resource.url to retrieve the url value." - ); - return this._url; - }, - }, - /** * The resource used to fetch the tileset JSON file * From 2837323d5d03d585a32792c68d46291b32fb17c6 Mon Sep 17 00:00:00 2001 From: Alex Gallegos <39537389+argallegos@users.noreply.github.com> Date: Mon, 22 Feb 2021 16:28:34 -0500 Subject: [PATCH 3/6] updated changes.md and contributors.md --- CHANGES.md | 7 +++++++ CONTRIBUTORS.md | 1 + 2 files changed, 8 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index 900cc634da53..00929f56d368 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -2,6 +2,13 @@ ### 1.79 - 2021-03-01 +##### Breaking Changes :mega: + +- Removed `Cesium3DTileset.url`, which was deprecated in v1.78. Use `Cesium3DTileset.resource.url` to retrieve the url value. +- Removed `EasingFunction.QUADRACTIC_IN`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_IN`. +- Removed `EasingFunction.QUADRACTIC_OUT`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_OUT`. +- Removed `EasingFunction.QUADRACTIC_IN_OUT`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_IN_OUT`. + ##### Fixes :wrench: - Fixed an issue that prevented use of the full CesiumJS zip release package in a Node.js application. diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 9bbf8a03bca8..b66f45ce29dd 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -150,6 +150,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu - [Erixen Cruz](https://github.com/ErixenCruz) - [Dzung Nguyen](https://github.com/dzungpng) - [Nithin Pranesh](https://github.com/nithinp7) + - [Alexander Gallegos](https://github.com/argallegos) - [Northrop Grumman](http://www.northropgrumman.com) - [Joseph Stein](https://github.com/nahgrin) - [EOX IT Services GmbH](https://eox.at) From c17cd38cdea992f4db3fb6a21309e4e0481123d1 Mon Sep 17 00:00:00 2001 From: Alex Gallegos <39537389+argallegos@users.noreply.github.com> Date: Mon, 22 Feb 2021 17:31:47 -0500 Subject: [PATCH 4/6] Removing unused deprecationwarning --- Source/Core/EasingFunction.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Source/Core/EasingFunction.js b/Source/Core/EasingFunction.js index ca537d660409..4521fda30d61 100644 --- a/Source/Core/EasingFunction.js +++ b/Source/Core/EasingFunction.js @@ -1,5 +1,4 @@ import Tween from "../ThirdParty/Tween.js"; -import deprecationWarning from "./deprecationWarning.js"; /** * Easing functions for use with TweenCollection. These function are from From 02a66f3c15ec15c214f610c821fed20953797bc9 Mon Sep 17 00:00:00 2001 From: Alex Gallegos <39537389+argallegos@users.noreply.github.com> Date: Mon, 22 Feb 2021 18:10:14 -0500 Subject: [PATCH 5/6] Remove trailing whitespace in changes.md --- CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 00929f56d368..ac77a43fdda7 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -7,7 +7,7 @@ - Removed `Cesium3DTileset.url`, which was deprecated in v1.78. Use `Cesium3DTileset.resource.url` to retrieve the url value. - Removed `EasingFunction.QUADRACTIC_IN`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_IN`. - Removed `EasingFunction.QUADRACTIC_OUT`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_OUT`. -- Removed `EasingFunction.QUADRACTIC_IN_OUT`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_IN_OUT`. +- Removed `EasingFunction.QUADRACTIC_IN_OUT`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_IN_OUT`. ##### Fixes :wrench: From 5143ed5bec40877818d06740e2bac611f17fb052 Mon Sep 17 00:00:00 2001 From: Sean Lilley Date: Mon, 22 Feb 2021 18:52:01 -0500 Subject: [PATCH 6/6] Tweaked CHANGES.md wording [skip ci] --- CHANGES.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index ac77a43fdda7..4f338d519f1d 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -4,10 +4,10 @@ ##### Breaking Changes :mega: -- Removed `Cesium3DTileset.url`, which was deprecated in v1.78. Use `Cesium3DTileset.resource.url` to retrieve the url value. -- Removed `EasingFunction.QUADRACTIC_IN`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_IN`. -- Removed `EasingFunction.QUADRACTIC_OUT`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_OUT`. -- Removed `EasingFunction.QUADRACTIC_IN_OUT`, which was deprecated in v1.77. Use `EasingFunction.QUADRATIC_IN_OUT`. +- Removed `Cesium3DTileset.url`, which was deprecated in CesiumJS 1.78. Use `Cesium3DTileset.resource.url` to retrieve the url value. +- Removed `EasingFunction.QUADRACTIC_IN`, which was deprecated in CesiumJS 1.77. Use `EasingFunction.QUADRATIC_IN`. +- Removed `EasingFunction.QUADRACTIC_OUT`, which was deprecated in CesiumJS 1.77. Use `EasingFunction.QUADRATIC_OUT`. +- Removed `EasingFunction.QUADRACTIC_IN_OUT`, which was deprecated in CesiumJS 1.77. Use `EasingFunction.QUADRATIC_IN_OUT`. ##### Fixes :wrench: @@ -82,8 +82,8 @@ ##### Breaking Changes :mega: -- Removed `MapboxApi`, which was deprecated in v1.72. Pass your access token directly to the `MapboxImageryProvider` or `MapboxStyleImageryProvider` constructors. -- Removed `BingMapsApi`, which was deprecated in v1.72. Pass your access key directly to the `BingMapsImageryProvider` or `BingMapsGeocoderService` constructors. +- Removed `MapboxApi`, which was deprecated in CesiumJS 1.72. Pass your access token directly to the `MapboxImageryProvider` or `MapboxStyleImageryProvider` constructors. +- Removed `BingMapsApi`, which was deprecated in CesiumJS 1.72. Pass your access key directly to the `BingMapsImageryProvider` or `BingMapsGeocoderService` constructors. ##### Additions :tada: