Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreal Engine is configuring libcurl for HTTP 1.1 #1295

Open
csciguy8 opened this issue Nov 16, 2023 · 2 comments
Open

Unreal Engine is configuring libcurl for HTTP 1.1 #1295

csciguy8 opened this issue Nov 16, 2023 · 2 comments
Labels
performance Improvements to performance, including reductions in memory usage

Comments

@csciguy8
Copy link
Contributor

There are most likely speed advantages from using HTTP 2.0, or even 3.0

From CurlHttp.cpp..

// HTTP2 is linked in for newer libcurl builds and the library will use it by default.
// There have been issues found with it use in production on long lived servers with heavy HTTP usage, for
// that reason we're disabling its use by default in the general purpose curl request wrapper and only
// allowing use of HTTP2 from other curl wrappers like the DerivedDataCache one.
// Note that CURL_HTTP_VERSION_1_1 was the default for libcurl version before 7.62.0
curl_easy_setopt(EasyHandle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);

Setting a breakpoint confirms that cesium-unreal executes this line, and there's no apparent way to configure it differently.

Thanks @kring for catching this.

@csciguy8 csciguy8 added the performance Improvements to performance, including reductions in memory usage label Nov 16, 2023
@steve3d
Copy link

steve3d commented May 9, 2024

any updates on this?

@csciguy8
Copy link
Contributor Author

csciguy8 commented May 9, 2024

From what I can tell, this code is unchanged (and still an issue) as of Unreal Engine 5.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improvements to performance, including reductions in memory usage
Projects
None yet
Development

No branches or pull requests

2 participants