Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better lighting for asset preview #3

Closed
mramato opened this issue May 7, 2018 · 1 comment
Closed

Better lighting for asset preview #3

mramato opened this issue May 7, 2018 · 1 comment

Comments

@mramato
Copy link
Contributor

mramato commented May 7, 2018

Currently, the asset preview window uses the browser's current local time, so if the asset being previewed is in a different part of the world (or it's night on the client), the asset is completely unlit and the preview is useless.

In the short term, we can fix this by computing when the sun will be overhead the center of the asset and use that time instead.

In the longer term, I wrote up CesiumGS/cesium#6553 so that CesiumJS provides us more lighting options.

@mramato mramato added the bug label May 7, 2018
@mramato
Copy link
Contributor Author

mramato commented May 9, 2018

Shipped as of yesterday.

@mramato mramato closed this as completed May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant