Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include Bootstrap in codepygments module #177

Closed
sloria opened this issue Jul 20, 2015 · 3 comments
Closed

Don't include Bootstrap in codepygments module #177

sloria opened this issue Jul 20, 2015 · 3 comments

Comments

@sloria
Copy link
Contributor

sloria commented Jul 20, 2015

I'm not sure that it's necessary to include Bootstrap for the codepygments module. We might just remove it.

Related issue: #176 - If we do need to include Boostrap, it would still be good to have a way to opt out of it.

@chrisseto
Copy link
Member

+1
it looks like bootstrap is only used for the error messages.
Foundation is included and I think it could be removed as well.

@mfraezz
Copy link
Member

mfraezz commented Aug 19, 2015

While it would prevent #175, some of the Boostrap rules are necessary. Otherwise, it will look like this:
screen shot 2015-08-19 at 14 21 05

Misalignment and lack of a border are obvious, but it's also not horizontally scrollable. A simple solution would be to just include the 10 or so rules that pygments actually needs to render things nicely in default.css, and remove the Bootstrap dependency.

Agree with @chrisseto about Foundation, it doesn't appear to be used anywhere at all.

@mfraezz
Copy link
Member

mfraezz commented Aug 19, 2015

In fact, nothing in /pdb/css/ appears to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants