-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BETA: Change About-Button links to internal Popups #174
Comments
Sad to see this vanishing in Beta, I always liked the links. Seems inevitably connected to #63. |
What code is needed to get this working? If someone can code the pop-up for one button, I can do the others. |
Ok, so what do we have to do to get this going? |
@SecUpwN or @d-mariano I need some input here. That input should consist of a simple PoC code to make a pop-up screen like the one we already have for the "Disclaimer"... |
@banjaxbanjo, huge thanks for the first PR to fix this Issue, here is the APK! I have been testing the new changes and would like you to have a look at a few things, hopefully not getting on your nerves:
Please excuse my nitpickyness, I hope you'll understand that I'm a very visual person. ;-) |
Thanks mate, Ive only installed on galaxy s5 and didnt have scroll isssues but will install on smaller device and try fix this scroll issue. Probably something to do with the click icons textview. The others are a quick fix will look into them later whem at computer and fix asap with your recommendations. I will also revert the credits to a non dialog was really a test to see what it looked like. Cheers Sent from Yahoo Mail on Android |
Before you revert that one, please have a look at which one looks better on both devices. Thank you for digging into the small things I just mentioned, I guess after those this Issue should really be solved. Update: @banjaxbanjo and I have discussed the rest of this Issue internally as it seems all the other links like |
In anticipation and preparation for the Beta stage of our application, we need to convert the help and information related links on the "About" page, from external web site (GitHub) links, to internal on-device (or in code) text files.
Q: Why is this an issue?
A: (1) It can be annoying to the user, that each button require you to start a web browser to be able to see the relevant information. (2) It may not be secure (or even possible), to browse the web at the time this information is needed.
Plan: Try to make our app as silent as possible without any external IP connections, apart from download OCID (and similar) data. But that is a location dependent and once in while operation.
The text was updated successfully, but these errors were encountered: