Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BETA: Change About-Button links to internal Popups #174

Closed
E3V3A opened this issue Nov 6, 2014 · 8 comments
Closed

BETA: Change About-Button links to internal Popups #174

E3V3A opened this issue Nov 6, 2014 · 8 comments

Comments

@E3V3A
Copy link
Contributor

E3V3A commented Nov 6, 2014

In anticipation and preparation for the Beta stage of our application, we need to convert the help and information related links on the "About" page, from external web site (GitHub) links, to internal on-device (or in code) text files.

Q: Why is this an issue?

A: (1) It can be annoying to the user, that each button require you to start a web browser to be able to see the relevant information. (2) It may not be secure (or even possible), to browse the web at the time this information is needed.

Plan: Try to make our app as silent as possible without any external IP connections, apart from download OCID (and similar) data. But that is a location dependent and once in while operation.

@SecUpwN SecUpwN changed the title BETA: Change About button links from external web to internal text files. BETA: Change About-Button links to internal Text-Popups Nov 6, 2014
@SecUpwN SecUpwN changed the title BETA: Change About-Button links to internal Text-Popups BETA: Change About-Button links to internal Popups Nov 6, 2014
@SecUpwN
Copy link
Member

SecUpwN commented Nov 6, 2014

Sad to see this vanishing in Beta, I always liked the links. Seems inevitably connected to #63.

@E3V3A
Copy link
Contributor Author

E3V3A commented Jan 17, 2015

What code is needed to get this working? If someone can code the pop-up for one button, I can do the others.

@SecUpwN
Copy link
Member

SecUpwN commented Jan 17, 2015

Dialogs

We can use dialogs. Also see this.

@E3V3A
Copy link
Contributor Author

E3V3A commented Jan 21, 2015

Ok, so what do we have to do to get this going?

@E3V3A
Copy link
Contributor Author

E3V3A commented Jan 29, 2015

@SecUpwN or @d-mariano I need some input here. That input should consist of a simple PoC code to make a pop-up screen like the one we already have for the "Disclaimer"...

@SecUpwN
Copy link
Member

SecUpwN commented Mar 19, 2015

@banjaxbanjo, huge thanks for the first PR to fix this Issue, here is the APK! I have been testing the new changes and would like you to have a look at a few things, hopefully not getting on your nerves:

  1. The CreditsRoll was perfect as it was before. Have you tested if the latest change into a popup makes it easier to read on devices with smaller screens? If it doesn't, I guess we can change it back.
  2. Not sure if this is an Issue with the padding, but the whole About-Page is now scrollable again. Maybe you can make the padding a little smaller so that everything fits on the site without scrolling?
  3. The text Click icons for detailed information should be colored red (like in the top title).
  4. The popups of the Status Icons are awesome. But when you click one of them, it would be great of the wording DETAILED EXPLANATION as well as the Icon and Status xyz could be centered. The text itself is just fine, I may do some smaller adjustments tonight if needed.

Please excuse my nitpickyness, I hope you'll understand that I'm a very visual person. ;-)

@ghost
Copy link

ghost commented Mar 19, 2015

Thanks mate,

Ive only installed on galaxy s5 and didnt have scroll isssues but will install on smaller device and try fix this scroll issue. Probably something to do with the click icons textview.

The others are a quick fix will look into them later whem at computer and fix asap with your recommendations.

I will also revert the credits to a non dialog was really a test to see what it looked like.

Cheers
Paul

Sent from Yahoo Mail on Android

@SecUpwN
Copy link
Member

SecUpwN commented Mar 19, 2015

I will also revert the credits to a non dialog was really a test to see what it looked like.

Before you revert that one, please have a look at which one looks better on both devices. Thank you for digging into the small things I just mentioned, I guess after those this Issue should really be solved.

Update: @banjaxbanjo and I have discussed the rest of this Issue internally as it seems all the other links like AIMSICD on GitHub, Documentation (WIKI), DISCLAIMER and so on shall be converted into internal links. We came to the conclusion that adding all these files adds unnecessary bloat, adds more difficulties in layout and the main thing, the Status Icons are now made available internally without having an internet connection. Thus, we see this as solved. Feel free to re-open if you don't agree. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants