Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Diagnostics.Activity support #9

Open
luckyycode opened this issue Aug 1, 2022 · 1 comment
Open

System.Diagnostics.Activity support #9

luckyycode opened this issue Aug 1, 2022 · 1 comment
Labels
feature-request New feature or request

Comments

@luckyycode
Copy link

luckyycode commented Aug 1, 2022

Since even Microsoft has started to integrate this ability to built-in classes (take a look on HttpClient) and with the growth of OpenTelemetry package, I'd like to make a proposal to integrate System.Diagnostics into CatraProto.

It does not require any thirdparty package and it's already integrated into net 5+ sdk. See https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.activitysource?view=net-6.0

Why?

It will be easier to find out any freezes or long executing methods using this thing. It will really help to diagnose any abnormal activity when using CatraProto. (For example, take a look on how it looks in Jaeger, Zipkin and sooo on, these are importers of telemetry and activities).

My proposal is made of a simple idea: insert ActivitySource into each publicly available CatraProto api method, with tags and requested data, that will make it easier to use for users and developers, unless needed.

@Aquathing Aquathing added the feature-request New feature or request label Aug 5, 2022
@Aquathing
Copy link
Collaborator

Would you be interested in implementing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants