Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we assign the same identifier to a name usage when the authorship changes? #1326

Open
mdoering opened this issue May 24, 2024 · 1 comment
Labels
matching xrelease Features for the extended release

Comments

@mdoering
Copy link
Member

mdoering commented May 24, 2024

When we add or remove an authorship the IdProvider issues a new identifier. This also happens for drastically different authorships which are considered not to be the same, e.g. Mill. -> DC.. This was done intentionally to advertise changes. With the eXtended release we are seeing many genera now with authorships that have been unqualified before, resulting in a different ID for them as in the corresponding base release.

Should we try to assign the same identifier if authorships are added or removed? Changing authors should still receive a new identifier.

@mdoering
Copy link
Member Author

We use a quick and custom logic for assigning identifiers now. Another option would be to use the name usage matching algorithm to select previous names and reuse their ids. But it would slow down a release quite a bit

@mdoering mdoering added xrelease Features for the extended release matching labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matching xrelease Features for the extended release
Projects
None yet
Development

No branches or pull requests

1 participant