Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column name sanity checks on cartodbfy #255

Open
danicarrion opened this issue May 10, 2016 · 0 comments
Open

Column name sanity checks on cartodbfy #255

danicarrion opened this issue May 10, 2016 · 0 comments

Comments

@danicarrion
Copy link

danicarrion commented May 10, 2016

Typical case:

create table books (Id integer, Name text);

Now, if you cartodbfy the table, it'll show up on the editor. However, the editor will fail to work properly with the table, because it'll fail to double-quote "Id" and "Name" on the SQL queries it sends, for instance, to filter data or to change the style of the map.

That's because our editor doesn't deal with column names that need to be put inside double quotes. We could tackle that, or we could let our users know that they need to do the sanity check themselves, but maybe a good trade off between complexity and bad UX could be to make cdb_cartodbfytable perform the sanity checks (and possibly correct what's wrong) itself.

cc @cartodave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant