fix for experiment schedular not working due to cyclic services depenency and findby() old syntax #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency and findby old syntax
VivekFitkariwala
requested changes
Nov 26, 2024
| @@ -28,7 +28,7 @@ export class ScheduledJobService { | |||
| return await this.dataSource.transaction(async (transactionalEntityManager) => { | |||
| try { | |||
| const scheduledJobRepository = transactionalEntityManager.getRepository(ScheduledJob); | |||
| const scheduledJob = await scheduledJobRepository.findOne({ where: { id }, relations: ['experiment'] }); | |||
| const scheduledJob = await scheduledJobRepository.findOne({ where: { id: id }, relations: ['experiment'] }); | |||
There was a problem hiding this comment.
Why this change?
There was a problem hiding this comment.
This new syntax was required for typeorm v0.3 upgrade. Without this the findOne would not return data.
There was a problem hiding this comment.
This is already in a new syntax. The only change I can see is {id} => {id: id} which is redundant.
There was a problem hiding this comment.
@VivekFitkariwala Fixed. Thanks.
backend/packages/Upgrade/src/api/services/ScheduledJobService.ts
Outdated
Show resolved
Hide resolved
|
@VivekFitkariwala Please check this: https://www.npmjs.com/package/typeorm 
|
VivekFitkariwala
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2135