Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS client lib malformed mark object #819

Closed
jreddig opened this issue May 2, 2023 · 0 comments · Fixed by #821
Closed

JS client lib malformed mark object #819

jreddig opened this issue May 2, 2023 · 0 comments · Fixed by #821
Assignees
Labels
bug Something isn't working

Comments

@jreddig
Copy link
Contributor

jreddig commented May 2, 2023

Describe the bug
JS client lib not sending the correct object to mark an experiment point

To Reproduce

const UpgradeClient = window["upgrade-client-lib"].UpgradeClient;
const upClient = new UpgradeClient("student1", "http://localhost:3030", "add");

window.onload = async () => {
	await upClient.init();
  const site = "site";
  const target = "target";
  const assignment = await upClient.getDecisionPointAssignment(site, target);
  const condition = assignment && assignment.getCondition();
  // MARKED_DECISION_POINT_STATUS.NO_CONDITION_ASSIGNED
  await upClient.markExperimentPoint(site, null, 'no condition assigned', target);
}

Expected behavior
The JS library should send an object like MarkExperimentValidatorv4

@jreddig jreddig added the bug Something isn't working label May 2, 2023
@jreddig jreddig linked a pull request May 2, 2023 that will close this issue
@jreddig jreddig self-assigned this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants