Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Prevent all inserts into experiment_error table, log instead #2122

Open
danoswaltCL opened this issue Nov 20, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working Needs Refined

Comments

@danoswaltCL
Copy link
Collaborator

In issue #1040 I commented out errorService.create() usage for the ErrorHandler middleware due to concerns about size and relevancy of the experiment_error table in an effort to cut off new inserts to this table while we determined what we wanted to do with it.

This left 2 places though where inserts can still happen, and these are still getting into the table and causing a problem because the table is still growing too fast.

image

The suggested fix here will finish that job and instead log the events instead of inserting them in the db.

This is a release bugfix because it will also make sure to prevent the profusion of "417" SERVER_ERROR.EXPERIMENT_USER_GROUP_NOT_DEFINED errors in prod when running group experiments, which are causing this table to grow pointlessly.

@danoswaltCL danoswaltCL self-assigned this Nov 20, 2024
@danoswaltCL danoswaltCL added bug Something isn't working Needs Refined labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs Refined
Projects
None yet
Development

No branches or pull requests

1 participant