Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We are using redundant class validators for various validation checks. #2042

Closed
ppratikcr7 opened this issue Oct 11, 2024 · 1 comment · Fixed by #2053
Closed

We are using redundant class validators for various validation checks. #2042

ppratikcr7 opened this issue Oct 11, 2024 · 1 comment · Fixed by #2053
Labels
bug Something isn't working enhancement New feature or request
Milestone
Program Increment...

Comments

@ppratikcr7
Copy link
Collaborator

Version where bug was found:
e.g "6.0.0"

Describe the bug
We are using a redundant @IsString and @IsDefined class validators throughout the codebase for validation checks at various places. The @IsString validation already takes place with the subsequent @IsUUID() validator internally. Same goes for @IsDefined which checks for !=null or !=undefined which is already being checked under @IsNotEmpty() which checks for != '' or !=null or !=undefined. We should remove these redundant class validators.
@ppratikcr7 ppratikcr7 added bug Something isn't working enhancement New feature or request labels Oct 11, 2024
@ppratikcr7 ppratikcr7 added this to the Program Increment PI13 milestone Oct 11, 2024
@ppratikcr7 ppratikcr7 self-assigned this Oct 11, 2024
@ppratikcr7 ppratikcr7 moved this to In Progress in UpGrade Project Oct 11, 2024
@danoswaltCL danoswaltCL reopened this Oct 11, 2024
@danoswaltCL
Copy link
Collaborator

oops didn't mean to close

@ppratikcr7 ppratikcr7 mentioned this issue Oct 14, 2024
Merged
@ppratikcr7 ppratikcr7 linked a pull request Oct 14, 2024 that will close this issue
Removing redundant class validators @IsDefined() and @IsString() #2053
Merged
@ppratikcr7 ppratikcr7 removed their assignment Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
UpGrade Project
Status: QA
Milestone
Program Increment PI13
Development

Successfully merging a pull request may close this issue.

Removing redundant class validators @IsDefined() and @IsString() CarnegieLearningWeb/UpGrade
2 participants
@ppratikcr7 @danoswaltCL