Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having segment property as List instead of Segment #1880

Closed
RidhamShah opened this issue Aug 29, 2024 · 0 comments · Fixed by #1879
Closed

Having segment property as List instead of Segment #1880

RidhamShah opened this issue Aug 29, 2024 · 0 comments · Fixed by #1879
Labels
bug Something isn't working epic: feature flags

Comments

@RidhamShah
Copy link
Collaborator

Describe the bug
In the backend, the FeatureFlagInclude array has the property List for a Segment, while the frontend code has the property name as Segment only. This creates confusion and requires adding code to change the property name from one to another during import.

Expected behaviour
For consistency, both property names should be defined as Segment.

@RidhamShah RidhamShah added bug Something isn't working epic: feature flags labels Aug 29, 2024
@RidhamShah RidhamShah self-assigned this Aug 29, 2024
@amurphy-cl amurphy-cl added this to the Program Increment PI13 milestone Aug 29, 2024
@amurphy-cl amurphy-cl moved this to In Progress in UpGrade Project Aug 29, 2024
@amurphy-cl amurphy-cl moved this from Code Review to QA in UpGrade Project Sep 10, 2024
@amurphy-cl amurphy-cl moved this from QA to Done in UpGrade Project Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic: feature flags
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants