Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore upsert() call to v5.2 release #1864

Closed
bcb37 opened this issue Aug 26, 2024 · 1 comment · Fixed by #1874
Closed

Restore upsert() call to v5.2 release #1864

bcb37 opened this issue Aug 26, 2024 · 1 comment · Fixed by #1874
Assignees
@bcb37
Labels
5.2 Typeorm priority: high High priority issue
Milestone
Program Increment...

Comments

@bcb37
Copy link
Collaborator

bcb37 commented Aug 26, 2024 •
edited
Loading

Add to release 5.2: Use the tpyeorm upsert() method for user creation, rather than save() (relates to: #1044)

The same change was merged to dev #1304 but was omitted in subsequent releases.
@bcb37 bcb37 converted this from a draft issue Aug 26, 2024
@bcb37 bcb37 added 5.2 Typeorm priority: high High priority issue labels Aug 26, 2024
@amurphy-cl amurphy-cl added this to the Program Increment PI13 milestone Aug 27, 2024
@amurphy-cl amurphy-cl moved this to Refined ToDo in UpGrade Project Aug 27, 2024
@ppratikcr7 ppratikcr7 linked a pull request Aug 28, 2024 that will close this issue
use upsert() when creating users #1874
Merged
@ppratikcr7
Copy link
Collaborator

@bcb37 Can we closer this ticket, it is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcb37 bcb37

Labels
5.2 Typeorm priority: high High priority issue
Projects
UpGrade Project
Status: Done
Milestone
Program Increment PI13
Development

Successfully merging a pull request may close this issue.

use upsert() when creating users CarnegieLearningWeb/UpGrade
3 participants
@bcb37 @ppratikcr7 @amurphy-cl