Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-flag root section card table #1555

Closed
danoswaltCL opened this issue May 20, 2024 · 4 comments · Fixed by #2008
Closed

Feature-flag root section card table #1555

danoswaltCL opened this issue May 20, 2024 · 4 comments · Fixed by #2008
Assignees
@Yagnik56
Labels
epic: feature flags release 6.0

Comments

@danoswaltCL
Copy link
Collaborator

Implement the basic root section card table, which should use mat-table to show paginated-flag details data.

Image

  • For this story, the concentration should be getting the basic layout and component wiring right and not worry about behavior yet like sort / filter / contex-chip / navigation / to next task so it's simple to review.

  • Should also handle the "empty" case also though (when no data is loaded):

Image

  • Otherwise, will need a load-spinner when data is pending.
@danoswaltCL danoswaltCL moved this to Refined ToDo in UpGrade Project May 20, 2024
@danoswaltCL danoswaltCL self-assigned this May 20, 2024
@danoswaltCL danoswaltCL moved this from Refined ToDo to In Progress in UpGrade Project May 23, 2024
@amurphy-cl amurphy-cl moved this from In Progress to Done in UpGrade Project May 28, 2024
@danoswaltCL danoswaltCL moved this from Done to QA in UpGrade Project Jul 10, 2024
@danoswaltCL danoswaltCL moved this from QA to Done in UpGrade Project Jul 16, 2024
@VivekFitkariwala
Copy link
Collaborator

VivekFitkariwala commented Sep 9, 2024 •
edited
Loading

The loader appears in the top left.

Image

@danoswaltCL @Yagnik56 @zackcl

@VivekFitkariwala VivekFitkariwala moved this from QA to Refined ToDo in UpGrade Project Sep 9, 2024
@Yagnik56
Copy link
Collaborator

Yagnik56 commented Sep 9, 2024

@VivekFitkariwala I created PR for it here.

@Yagnik56 Yagnik56 moved this from Refined ToDo to Done in UpGrade Project Sep 9, 2024
@ppratikcr7 ppratikcr7 moved this from Done to QA in UpGrade Project Sep 25, 2024
@ppratikcr7
Copy link
Collaborator

QA Done: Working as expected.

@ppratikcr7 ppratikcr7 moved this from QA to Done in UpGrade Project Sep 25, 2024
@ppratikcr7 ppratikcr7 moved this from Done to Refined ToDo in UpGrade Project Oct 3, 2024
@ppratikcr7
Copy link
Collaborator

QA: @Yagnik56 I observed the same spinner top left issue in feature flag details page. Can you please resolve this as well?
Screenshot 2024-10-03 at 2 17 14 PM

@Yagnik56 Yagnik56 linked a pull request Oct 3, 2024 that will close this issue
Align spinner and make font bold in feature flag name on ff deatils page #2008
Merged
@ppratikcr7 ppratikcr7 assigned Yagnik56 and unassigned ppratikcr7 Oct 3, 2024
@ppratikcr7 ppratikcr7 moved this from Refined ToDo to Code Review in UpGrade Project Oct 3, 2024
@ppratikcr7 ppratikcr7 moved this from Code Review to Done in UpGrade Project Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yagnik56 Yagnik56

Labels
epic: feature flags release 6.0
Projects
UpGrade Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align spinner and make font bold in feature flag name on ff deatils page CarnegieLearningWeb/UpGrade
4 participants
@VivekFitkariwala @ppratikcr7 @Yagnik56 @danoswaltCL