Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Users UI bugs #1329

Closed
RidhamShah opened this issue Feb 28, 2024 · 1 comment · Fixed by #1336 or #1355
Closed

Preview Users UI bugs #1329

RidhamShah opened this issue Feb 28, 2024 · 1 comment · Fixed by #1336 or #1355
Assignees
Labels
bug Something isn't working release 6.0

Comments

@RidhamShah
Copy link
Collaborator

RidhamShah commented Feb 28, 2024

Describe the bugs
There are various UI bugs for Preview Users

  • Preview Users data not loading on Preview Users Tab
  • Data not loading on hard refresh
  • Scroll bar showing unnecessary on Preview-User list
  • Scroll bar showing unnecessary on each preview-user while adding experiment-condition to assign
    image
    image

Expected behavior
The preview users should load the data on initialization.
On showing all experiment-condition assignments for a Preview-user the data should have an auto-height increment.
For adding assignments to a Preview-User only a vertical scroll bar should be present if it exceeds the height limit only.

Steps to reproduce
Create an experiment with the state as Preview
Add users for Preview in Preview-Users Menu.
Clicking on the Experiment Menu and then on Participants(Preview-User) the user data inserted won't be shown
Also hard refreshing the page the preview-users data won't be shown

@RidhamShah RidhamShah added the bug Something isn't working label Feb 28, 2024
@RidhamShah RidhamShah self-assigned this Feb 28, 2024
@RidhamShah RidhamShah moved this to In Progress in UpGrade Project Feb 28, 2024
@RidhamShah RidhamShah linked a pull request Mar 4, 2024 that will close this issue
@RidhamShah RidhamShah moved this from In Progress to Code Review in UpGrade Project Mar 4, 2024
@RidhamShah RidhamShah moved this from Code Review to QA in UpGrade Project Mar 5, 2024
@bcb37
Copy link
Collaborator

bcb37 commented Mar 7, 2024

QA: Preview users are still not displayed the first time you load the page. Now you can make them appear by changing pages, as well as changing tabs - but they should also appear initially.

@bcb37 bcb37 reopened this Mar 7, 2024
@github-project-automation github-project-automation bot moved this from QA to In Progress in UpGrade Project Mar 7, 2024
@RidhamShah RidhamShah linked a pull request Mar 11, 2024 that will close this issue
@RidhamShah RidhamShah moved this from In Progress to Code Review in UpGrade Project Mar 11, 2024
@danoswaltCL danoswaltCL moved this from Code Review to QA in UpGrade Project Mar 11, 2024
@bcb37 bcb37 moved this from QA to Done in UpGrade Project Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release 6.0
Projects
Status: Done
3 participants