Buttons Disappear When the Page is Refreshed

[zackcl]

Version where bug was found:
5.1.0

Describe the bug
When the Experiments or Segments list page is refreshed, some or all of the buttons at the top (e.g., "Add Experiment") disappear.

To Reproduce
Steps to reproduce the behavior:

1. Go to the Experiments or Segments list page.
2. Refresh the page.
3. Observe that some buttons are not visible on the page.

Expected behavior
The buttons should remain visible upon page refresh.

Screenshots

buttons-disappear.mov

[danoswaltCL]

Welp. I know what this probably is, I'll take this. This very likely is related to the fix where I dealt with auth and how pages reroute when refresh happens. These buttons disappear if a user doesn't have certain permissions, something's not working right apparently.

[zackcl]

QA: @zackcl

[zackcl]

@danoswaltCL I'm not sure if these are directly related to this issue, but here are a few problems I've noticed:

• When the Segment details page is refreshed, the status changes to Unused.
• Signing out from the Experiment or Segment details page triggers a "TypeError: Cannot destructure property 'state' of 'undefined' as it is undefined." error.
• Signing back in directs the user to the Segment (or Experiment) details page, but it might be more intuitive to default to the Experiments list page.
• Occasionally, refreshing the Segment details page (in either the Global or Used state) causes a "TypeError: Cannot read properties of null (reading 'segments')" error (refer to the screenshot at the bottom)."

refresh-issues.mov

[danoswaltCL]

Ok, back to the drawing board, I can take this back into progress and take a look, can create separate issues if they are indeed separate. Does this feel like it should be prioritized as a 5.1 release bugfix @amurphy-cl ? They don't appear like big blockers, but we're still yet to really start testing the release.

@zackcl you're saying it's not intuitive to go back to the URL you were last on after logging back in? this is indeed new behavior in this release, it used to always redirect to the experiment list home. It was changed in my stories to fix the persistent auth, now it will always redirect to the url you had been on before going to the login screen.

The more important thing about is that now we can share urls of experiment and segment detail pages, which was a story that spawned off of the persistent auth stuff because fixing that revealed that this still didn't work as intended. Previously if you clicked on a detail url, you may get prompted to login, and then it would redirect you to the home root. Not very helpful if you were expecting to see a details page! Now you if you click a url and need to login, you'll be able to view the shared page after logging in.

[zackcl]

@danoswaltCL Regarding the sharing of URLs, I understand the rationale behind it, and that aspect makes sense. However, I find it somewhat unconventional to be directed back to a details page upon logging in. It's akin to being taken directly to an open email when logging back into Gmail, rather than seeing the inbox overview. This behavior might be unexpected for users.

[danoswaltCL]

Putting back into in progress to fix:

• Clear redirect url after logout
• Status should stay the same
• Check out the other erros

[danoswaltCL]

@zackcl can you re-review? I fixed all but the "status" one, which I created a separate new ticket to investigate, it could require some extra refactor instead trying a quick fix, i think there's an underlying problem that should get fixed.

[zackcl]

@danoswaltCL I can confirm that issues 2 and 3 are resolved, but issues 1 and 4 seem to remain. I think we can close this if you created a separate ticket for these two remaining issues.

1. When the Segment details page is refreshed, the status changes to Unused.
2. Signing out from the Experiment or Segment details page triggers a "TypeError: Cannot destructure property 'state' of 'undefined' as it is undefined." error.
3. Signing back in directs the user to the Segment (or Experiment) details page, but it might be more intuitive to default to the Experiments list page.
4. Occasionally, refreshing the Segment details page (in either the Global or Used state) causes a "TypeError: Cannot read properties of null (reading 'segments')" error (refer to the screenshot at the bottom)."

Here's the screenshot showing the issues 1 and 4:

[danoswaltCL]

ok, issue 1 has a ticket, I see 4 now I missed that. I have an idea what me going on there.

[danoswaltCL]

issue 4 fix: https://github.com/CarnegieLearningWeb/UpGrade/pull/1327/files

[danoswaltCL]

I believe this one can be reviewed and hopefully closed now.

[zackcl]

QA: Passed