Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick Java Lib 3x changes down into 4x, 5x #1139

Closed
danoswaltCL opened this issue Nov 20, 2023 · 4 comments
Closed

Cherry-pick Java Lib 3x changes down into 4x, 5x #1139

danoswaltCL opened this issue Nov 20, 2023 · 4 comments
Assignees
@bcb37 @danoswaltCL
Labels
release 5.1

Comments

@danoswaltCL
Copy link
Collaborator

danoswaltCL commented Nov 20, 2023 •
edited
Loading

Retries were modified in the latest patch of v3 Java lib. These changes need to be merged down so they are in sync with 4x (release/v4.1 branch), 5x (release/v5.0).
@danoswaltCL danoswaltCL moved this to In Progress in UpGrade Project Nov 20, 2023
@danoswaltCL danoswaltCL moved this from In Progress to Code Review in UpGrade Project Nov 20, 2023
@danoswaltCL danoswaltCL self-assigned this Nov 20, 2023
@danoswaltCL
Copy link
Collaborator Author

danoswaltCL commented Nov 20, 2023 •
edited
Loading

Version 4: #1058
Version 5: #1140

@danoswaltCL danoswaltCL changed the title Merge Java Lib 3x changes down into 4x, 5x, and dev Merge Java Lib 3x changes down into 4x, 5x Nov 20, 2023
@danoswaltCL danoswaltCL changed the title Merge Java Lib 3x changes down into 4x, 5x Cherry-pick Java Lib 3x changes down into 4x, 5x Nov 20, 2023
@danoswaltCL
Copy link
Collaborator Author

@bcb37 @jerith666 created this story lest we forget to do this, technically both are cherry-picks of the retries commit. Once these changes are merged in I'll republish the Java artifacts for this updated version in Nexus.

@danoswaltCL danoswaltCL moved this from Code Review to QA in UpGrade Project Nov 20, 2023
@danoswaltCL
Copy link
Collaborator Author

Java lib artifacts updated in Nexus:
4.1.14
5.0.13

@bcb37
Copy link
Collaborator

bcb37 commented Nov 30, 2023

Tested v5.0 and v4.1 - retry works as expected for
200s: no regressions
400s: no retries
500s: one retry

@bcb37 bcb37 closed this as completed Nov 30, 2023
@bcb37 bcb37 moved this from QA to Done in UpGrade Project Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcb37 bcb37

@danoswaltCL danoswaltCL

Labels
release 5.1
Projects
UpGrade Project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcb37 @danoswaltCL